[cpullvm] Add xqci variants with exceptions, rtti enabled - #660
Draft
Jonathon Penix (jonathonpenix) wants to merge 3 commits into
Draft
Jonathon Penix (jonathonpenix) wants to merge 3 commits into
Jonathon Penix (jonathonpenix) wants to merge 3 commits into
Conversation
Two new variants were added, both built with exception and rtti support - riscv32ima_xqci_ilp32_exn_rtti_nopic - riscv32ima_zinx_xqci_ilp32_exn_rtti_nopic Note that these will now be matched rather than the old riscv32ima_xqci_ilp32_nopic or riscv32ima_zinx_xqci_ilp32_nopic unless users explicitly pass -fno-exceptions AND -fno-rtti, even when building ex: C code. If they pass both, they should get the old variants. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Jonathon Penix (jonathonpenix)
requested review from
Ana Pazos (apazos),
Pankaj Gode (pgodeq) and
Sudharsan Veeravalli (svs-quic)
September 8, 2026 22:37
Jonathon Penix (jonathonpenix)
marked this pull request as draft
September 8, 2026 23:05
Contributor
Author
|
Sorry, marking this as a draft since I have to go back and add a bunch of xfails. |
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Contributor
Author
|
Right now there are ~4 libc++ failures that need to be sorted out with these variants:
Otherwise, other tests (picolibc, compiler-rt, libunwind, libcxxabi, multilib) are passing locally |
Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Contributor
|
Thanks Jonathon for putting this together. I had missed adding -fno-exceptions and -fno-rtti for the earlier variants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new variants were added, both built with exception and rtti support
Note that these will now be matched rather than the old riscv32ima_xqci_ilp32_nopic or riscv32ima_zinx_xqci_ilp32_nopic variants unless users explicitly pass -fno-exceptions AND -fno-rtti, even when building ex: C code. If they pass both, they should get the old variants.
Note also that riscv32ima_xqci_ilp32_exn_rtti_nopic is being added for libc++ testing--I think it is worth having at least one extension + rtti variant enabled since this is new for us.