Test the A.4.27 signed subset expansion - #25
Open
utiberious wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #16.
This adds a concrete
Cl3test for Appendix A.4.27 of arXiv:1205.5935. It usesB₂ = e₁ ∧ e₂ + 2(e₂ ∧ e₃),a₁ = e₁ + e₂,a₂ = e₂ + e₃, anda₃ = e₃ + e₁, then verifies the+, -, +two-element-subset expansion forB₂ ⨼ (a₁ ∧ a₂ ∧ a₃).The left-hand side and all three summands are nonzero, and the test checks their exact components. The required sign pattern is unique for this witness: each of the other seven sign choices produces a different result.
PR #18 adds
@testto three expressions already present in the suite. This patch covers the separate A.4.27 gap, so the changes are complementary.Tested with Julia 1.10.11 and Python
galgebra==0.6.0:julia --project=. -e 'using Pkg; Pkg.test()'Result: 1,340 passed, 1 pre-existing broken, 1,341 total.