Skip to content

Fix A.4.35 rejection identity test - #24

Open
utiberious wants to merge 2 commits into
pygae:masterfrom
utiberious:utiberious/fix-a435-rejection
Open

Fix A.4.35 rejection identity test#24
utiberious wants to merge 2 commits into
pygae:masterfrom
utiberious:utiberious/fix-a435-rejection

Conversation

@utiberious

Copy link
Copy Markdown

Closes #15.

Appendix A.4.35 of arXiv:1205.5935 states the orthogonal rejection identity

(B ∧ Aᵣ) * inv(Aᵣ) == (B ∧ Aᵣ) ⨽ inv(Aᵣ)

Reflection is a separate sandwich transformation, so this removes the incorrect refl(...) comparison and promotes the rejection identity to a passing test. It also updates the adjacent broken-test summary.

This replaces the remaining A.4.35 framing in #20.

Verification:

  • Julia 1.10.11
  • GAlgebra test suite: 1332 passed / 1332 total
  • Negative control: the former reflection/rejection comparison evaluates false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken test A.4.35

1 participant