Skip to content

CI: Fix PHP7.4 build #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 6 commits into from
Sep 4, 2026
Merged

CI: Fix PHP7.4 build #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cd932f
Fix PHP7.4 build
staabm Sep 4, 2026
08705fa
Update composer.json
staabm Sep 4, 2026
7057ad9
fix
staabm Sep 4, 2026
1df960b
Revert "Update composer.json"
staabm Sep 4, 2026
4e3672e
Update composer.json
staabm Sep 4, 2026
a327d12
cs
staabm Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Rules/PHPUnit/TestMethodsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use PHPStan\Type\FileTypeMapper;
use PHPUnit\Framework\TestCase;
use function array_key_exists;
use function str_starts_with;
use function strpos;
use function strtolower;

final class TestMethodsHelper
Expand Down Expand Up @@ -62,7 +62,7 @@ public function getTestMethods(ClassReflection $classReflection, Scope $scope):
continue;
}

if (str_starts_with(strtolower($reflectionMethod->getName()), 'test')) {
if (strpos(strtolower($reflectionMethod->getName()), 'test') === 0) {
$testMethods[] = $reflectionMethod;
continue;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use PHPStan\Analyser\Scope;
use PHPUnit\Framework\TestCase;
use function is_string;
use function str_starts_with;
use function strpos;

final class DynamicCallToAssertionIgnoreExtension implements IgnoreErrorExtension
{
Expand All @@ -33,7 +33,7 @@ public function shouldIgnore(Error $error, Node $node, Scope $scope): bool

if (
!$node->name instanceof Node\Identifier
|| !str_starts_with($node->name->name, 'assert')
|| strpos($node->name->name, 'assert') !== 0
) {
return false;
}
Expand Down
Loading