[TASK] Rename DirectiveRule::parseDirectiveContent() to parseDirectiveValue() - #1391
Merged
Conversation
…eValue() The method only ever parses the text right after `::` -- a directive's own value -- into inline markup. It has nothing to do with a directive's body/content, the indented block on later lines, which collectDirectiveContents() collects entirely separately. The old name invited exactly that confusion. Signed-off-by: linawolf Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method only ever parses the text right after
::-- a directive'sown value -- into inline markup. It has nothing to do with a
directive's body/content, the indented block on later lines, which
collectDirectiveContents() collects entirely separately. The old name
invited exactly that confusion.
Signed-off-by: linawolf
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT