Conversation
…resql tests The reverse-engineered SQL tests hardcoded 'postgres' as the role name in test JSON data and expected SQL files. This fails on systems where the superuser is not 'postgres' (e.g. 'ashesh.vashi'). Changes: - Replace hardcoded 'postgres' with '<OWNER>' placeholder in ~400 test JSON, SQL, and MSQL files across all browser module tests - Extend test_resql.py to resolve '<OWNER>' in scenario data sent to API endpoints (not just in expected SQL) - Handle identifier quoting for usernames containing special characters (dots, etc.) by normalizing both expected and actual SQL - Fix test_domain_sql.py to use qtIdent for username in expected SQL - Split Authlib version pin: 1.6.x for Python <=3.9, 1.7.x for >3.9 Result: 2408 pass, 1 fail (pre-existing schema_diff backup issue) Previously: 1652 pass, 43 fail
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postgresrole with<OWNER>placeholder in ~400 resql test data files (JSON, SQL, MSQL), so tests pass on systems where the superuser is notpostgres(e.g.ashesh.vashi)test_resql.pyto resolve<OWNER>in API request data and normalize identifier quoting for usernames with special characters (dots, etc.)test_domain_sql.pyto useqtIdentfor username in expected SQL comparisonschema_difftest restore to replace hardcodedpostgresrole with actual test user1.6.*for <=3.9,1.7.*for >3.91.2.*for <=3.9,1.3.*for >3.90.5.0for <=3.9,0.6.1for >3.9Test plan