Skip to content

Fixed an issue where the result grid slowed down when large JSON data was loaded #8762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityatoshniwal merged 6 commits into from
May 21, 2025
Merged

Fixed an issue where the result grid slowed down when large JSON data was loaded #8762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea859d9
Fixed an issue where the result grid slowed down when large JSON data…
pravesh-sharma May 8, 2025
4f4ea03
Added preference for max lenght and css related changes.
pravesh-sharma May 20, 2025
9e32f8b
Resolved conflict in yarn.lock
pravesh-sharma May 20, 2025
b0acf34
Fixed pep8
pravesh-sharma May 20, 2025
6d4f85c
Fixed feature test failure and updated docs
pravesh-sharma May 21, 2025
a659148
Fixed query tool feature test failure
pravesh-sharma May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/en_US/images/preferences_sql_results_grid.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions docs/en_US/preferences.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,9 @@ preferences for copied data.
setting won't have any effect.
* Specify the number of records to fetch in one batch. Changing this value will
override DATA_RESULT_ROWS_PER_PAGE setting from config file.
* Use the *Max column data display length* to specify the maximum number of
characters to display in a cell. If the data is larger than this value, it
will be truncated.
* Use the *Result copy field separator* drop-down listbox to select the field
separator for copied data.
* Use the *Result copy quote character* drop-down listbox to select the quote
Expand Down
2 changes: 1 addition & 1 deletion web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@
"insert-if": "^1.1.0",
"ip-address": "^10.0.1",
"json-bignumber": "^1.0.1",
"jsoneditor": "^10.1.2",
"leaflet": "^1.9.4",
"lodash": "4.*",
"moment": "^2.29.4",
Expand Down Expand Up @@ -150,6 +149,7 @@
"uplot": "^1.6.32",
"uplot-react": "^1.1.4",
"valid-filename": "^4.0.0",
"vanilla-jsoneditor": "^3.3.1",
"wkx": "^0.5.0",
"zustand": "^5.0.3"
},
Expand Down
1 change: 0 additions & 1 deletion web/pgadmin/static/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

@import 'node_modules/@xterm/xterm/css/xterm.css';

@import 'node_modules/jsoneditor/dist/jsoneditor.min.css';
@import 'node_modules/react-checkbox-tree/lib/react-checkbox-tree.css';

@import 'node_modules/@simonwep/pickr/dist/themes/monolith.min.css';
Expand Down
5 changes: 5 additions & 0 deletions web/pgadmin/static/js/Theme/overrides/codemirror.override.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export default function cmOverride(theme) {
const editor = theme.otherVars.editor;
return {
'.cm-editor': {
// CSS variables for jsoneditor's CodeMirror
'--jse-font-family-mono': theme.typography.fontFamilySourceCode,
'--jse-panel-background': editor.guttersBg,
'--jse-panel-color-readonly': editor.guttersFg,
'--jse-panel-border': 'none',
height: '100%',
color: editor.fg,
backgroundColor: editor.bg,
Expand Down
Loading