(docs) fixes venv notations for web build#8752
Merged
akshay-joshi merged 2 commits intopgadmin-org:masterfrom May 14, 2025
Merged
(docs) fixes venv notations for web build#8752akshay-joshi merged 2 commits intopgadmin-org:masterfrom
akshay-joshi merged 2 commits intopgadmin-org:masterfrom
Conversation
khushboovashi
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making and supporting this, it is a super useful tool to work with postgres.
I am proposing these changes in the hopes of streamlining the setup process for others hoping to contribute. AFAICT the
install-nodeandbundletargets don't require venv, so it seems better to omit that to avoid any confusion. To test this I ran those two commands before setting up the venv, proceeded through the rest of the instructions and confirmed I was able to view the UI in the browser after runningpgAdmin4.py.If there is any other testing or cleanup of the PR needed I'm happy to do so, thanks again!