TX16S MK3 Lua fixes - #1186
Open
wiilover22 wants to merge 2 commits into
Open
Conversation
Small set of fixes for the slightly larger screen on a MK3.
Owner
|
I'm guessing all the values you've changed are ok for the bigger screens of the MK3 but will break the smaller color ones MK1 and 2. May be define them as a variable and change the value based on the screen size? |
Author
|
I will see what I can do. I'll look at the DSM-tools script, and perhaps try using a variant of that solution. |
Hopefully this doesn't break something I'm unaware of... Set a switch to check for color LCD, then check for LCD size for all scripts. Made all the UI elements a bit more uniform across the different scripts. I also removed two unused variables in `Graupner Hott.lua`.
Author
|
Well, here's attempt number 2. I'm a little out of my depth here...but trying my best =x Hopefully this works on other devices, as I've only been able to test these scripts on my MK3. |
Owner
|
I have a MK2 so I can test tomorrow too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small set of fixes for the slightly larger screen on a MK3.
I've tested these on my TX16S MK3 running EdgeTX v2.12.2. All scripts now run without error, and display properly on an MK3.
I do not have other TX's, so I cannot test if my changes have broke other things.
I apologize if I've done any of this incorrectly...first time trying a pull request =P