refactor: Bump brace-expansion from 1.1.13 to 1.1.18 - #276
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe pull request updates ChangesDependency refresh
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This dependency-only update preserves supported Node.js versions and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Out of Scope Changes checkExplanation All changes are limited to Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Security CheckExplanation PASS. The pull request changes only Full details: Engage In Review FeedbackExplanation PASS: No substantive review feedback was present for this pull request. The exact PR ( ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 159 159
=========================================
Hits 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Pull Request
Issue
Closes #274
Dependabot security update for the transitive dependency
brace-expansion. This PR replaces the Dependabot PR because bot branches cannot be modified directly, so the change is reproduced here on a branch that can be reviewed and adjusted.Approach
Bumps the transitive dependency
brace-expansionto pick up the fix for GHSA-3jxr-9vmj-r5cp / CVE-2026-13149: a denial of service caused by exponential-time (O(2^n)) expansion of consecutive non-expanding{}groups inexpand(). A short crafted input can block the event loop for minutes. The advisory is patched in1.1.16on the 1.x line and in5.0.7on the 5.x line.brace-expansionis not listed inpackage.json; it is pulled in transitively throughminimatch. Therefore onlypackage-lock.jsonchanges —package.jsonis untouched andlockfileVersion: 3is preserved.The bump was applied with
npm update brace-expansion --ignore-scripts, which resolves each instance to the newest version permitted by its parent's semver range:node_modules/glob/node_modules/brace-expansion@babel/cli›glob›minimatch1.1.131.1.18node_modules/brace-expansioneslint›minimatch5.0.55.0.9Notes on the resolved versions:
1.1.16, but^1.1.7resolves to1.1.18, the current 1.x release. It contains the same advisory fix, so the result is ahead of the bot's target rather than behind it. The lockfile was not hand-edited to force an exact1.1.16pin.5.0.5entry was also affected by the same advisory (patched from5.0.7), so it is bumped to5.0.9in the same pass.npm(via@semantic-release/npm) resolves to5.0.7, which is already patched and is not modifiable from this repository's lockfile.Engine compatibility:
brace-expansion@5.0.9declaresengines.node: "20 || >=22". This repository requires"20 || 22 || 24"and CI runs Node20.19.5,22.21.1and24.11.1, so all supported versions remain satisfied.Verification:
npm ci --ignore-scriptscompletes successfully andnpm ls brace-expansion --allresolves the tree without conflicts or peer dependency breakage. No vulnerablebrace-expansionversion remains in the dependency tree.Tasks
npm ci --ignore-scripts,npm ls brace-expansion --all)Tests and documentation changes do not apply: this is a lockfile-only bump of a transitive development dependency with no source, API or behavior changes.
Summary by CodeRabbit