chore: remove unused loadRefreshToken and loadAccessToken stubs - #32785
chore: remove unused loadRefreshToken and loadAccessToken stubs#32785detail-app[bot] wants to merge 1 commit into
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 556 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 49m 16s ⏱️ Max setup 4m 33s · max shard execution 19m 26s · max shard-job elapsed before upload 23m 9s · reporting 4s 🌐 234.28 requests/attempt · 2.82 app boots/UI scenario · 13.72% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Removed the
loadRefreshToken(OAuthClientInformation, String)andloadAccessToken(String)declarations from theOAuthAuthorizationServerProviderinterface, their@Overrideimplementations in
UserSSOOAuthProvider, and the now-unusedorg.openmetadata.mcp.auth.AccessTokenimport.These were dead code: both overrides threw
UnsupportedOperationException(comments stated "not used in the current implementation") and had zero
production callers and zero test callers. The interface is internal to
OpenMetadata (the MCP SDK jar has no
OAuthAuthorizationServerProviderofits own, so this is not mirroring an external contract).
exchangeRefreshTokenandJwtFilterare the live paths that supersededthem.
registerClientandrevokeTokenwere left in place: their overridesare functional rather than stubs.
History
Tooling: Detail: Dead Code
Dead Code PRs can be configured here.