Skip to content

chore: remove unused loadRefreshToken and loadAccessToken stubs - #32785

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-loadrefreshtoken-and-loadacces-4234ca
Open

chore: remove unused loadRefreshToken and loadAccessToken stubs#32785
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-loadrefreshtoken-and-loadacces-4234ca

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Removed the loadRefreshToken(OAuthClientInformation, String) and
loadAccessToken(String) declarations from the
OAuthAuthorizationServerProvider interface, their @Override
implementations in UserSSOOAuthProvider, and the now-unused
org.openmetadata.mcp.auth.AccessToken import.

These were dead code: both overrides threw UnsupportedOperationException
(comments stated "not used in the current implementation") and had zero
production callers and zero test callers. The interface is internal to
OpenMetadata (the MCP SDK jar has no OAuthAuthorizationServerProvider of
its own, so this is not mirroring an external contract).
exchangeRefreshToken and JwtFilter are the live paths that superseded
them. registerClient and revokeToken were left in place: their overrides
are functional rather than stubs.

History

Tooling: Detail: Dead Code


Dead Code PRs can be configured here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit d6d097313340138e72ee38c91e0940b332c593a9 in Playwright run 34071164978, attempt 1.

✅ 556 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 49m 16s

⏱️ Max setup 4m 33s · max shard execution 19m 26s · max shard-job elapsed before upload 23m 9s · reporting 4s

🌐 234.28 requests/attempt · 2.82 app boots/UI scenario · 13.72% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 234.28 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 579 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
🟡 Shard chromium-01 146 0 1 0 0 0
✅ Shard chromium-02 130 0 0 0 0 0
✅ Shard chromium-03 122 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsGlossary Term Add, Update and Remove for child entities (shard chromium-01, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant