Skip to content

chore: remove unused audience field from AccessToken - #32783

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-audience-field-from-accesstoke-83eeab
Open

chore: remove unused audience field from AccessToken#32783
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-audience-field-from-accesstoke-83eeab

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Removed the audience field, the 5-arg AccessToken constructor,
getAudience(), and setAudience() from
openmetadata-mcp/.../auth/AccessToken.java (19 lines). No callers
exist anywhere in the codebase (production or test): the 5-arg
constructor is never invoked, audience is never read or written,
and OAuthTokenRepository neither persists nor hydrates it — the
field is silently lost on every round-trip. The sibling RefreshToken
class's 5th constructor parameter is userName, not audience, so
this is not a parallel-class convention.

History


Dead Code PRs can be configured here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 696dc69ae928c5a3876dd8b4f2f0cfe3290c40da in Playwright run 34070148139, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 48m 35s

⏱️ Max setup 4m 8s · max shard execution 19m 17s · max shard-job elapsed before upload 23m 5s · reporting 4s

🌐 234.62 requests/attempt · 2.82 app boots/UI scenario · 30.68% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 30.68% (convergence target: at most 15%).
  • Browser traffic was 234.62 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 147 0 0 0 0 0
✅ Shard chromium-02 130 0 0 0 0 0
✅ Shard chromium-03 122 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant