Skip to content

chore: remove unused MCP McpUtils helpers - #32782

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-mcp-mcputils-helpers-887a2a
Open

chore: remove unused MCP McpUtils helpers#32782
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-mcp-mcputils-helpers-887a2a

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Describe your changes:

Removes two unused public methods from McpUtils and the four imports that became dead as a result:

  • getJsonRpcMessageWithAuthorizationParam(McpJsonMapper, HttpServletRequest, String)
  • readRequestBody(HttpServletRequest)

Both had zero callers anywhere in the codebase (production, tests, or resource files). Their sole historical consumers — MCPStreamableHttpServlet (1007 lines) and HttpServletSseServerTransportProvider (429 lines) — were deleted in PR #23049 (Upgrade Mcp to 0.11.2), which rewrote the MCP HTTP transport around OAuthHttpStatelessServerTransportProvider. The Authorization header is now extracted by AuthEnrichedMcpContextExtractor instead of being mutated into JSON-RPC params, so these helpers were left dangling and their pattern is architecturally obsolete.

History

Type of change:

  • Improvement

High-level design:

N/A — small dead-code removal.

Tests:

Existing McpSdkUpgradeTest (19 tests, exercising McpUtils.getToolProperties and McpUtils.getPrompts) passes after the change. mvn compile -pl openmetadata-mcp and mvn spotless:check are clean. No tests referenced the removed methods.

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from harshach September 7, 2026 00:24
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit bf43c830ee1419f794669ba122d380c01920c28c in Playwright run 34070961200, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 45m 22s

⏱️ Max setup 4m 11s · max shard execution 19m 33s · max shard-job elapsed before upload 22m 41s · reporting 4s

🌐 234.41 requests/attempt · 2.82 app boots/UI scenario · 17.39% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 17.39% (convergence target: at most 15%).
  • Browser traffic was 234.41 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 147 0 0 0 0 0
✅ Shard chromium-02 130 0 0 0 0 0
✅ Shard chromium-03 122 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant