Skip to content

chore: remove dead AccessTokenResponse model from java-client - #32779

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-dead-accesstokenresponse-model-from-j-66878c
Open

chore: remove dead AccessTokenResponse model from java-client#32779
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-dead-accesstokenresponse-model-from-j-66878c

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Remove the entire AccessTokenResponse class (146 LOC) and its nested
GrantType enum from the deprecated openmetadata-java-client module.

The class was the only one of the 7 remaining files in the
openmetadata-java-client module with zero references anywhere in the
tree. All five of its consumers (the Auth0/Okta/CustomOIDC
authentication providers and the Auth0/Okta access-token Feign APIs)
were deliberately deleted in #14358 (Dec 2023, "Clean ingestion ES
code and auth providers"), leaving it the orphaned envelope of a
removed feature. It was then marked @deprecated(since="1.12.0",
forRemoval=true) in #26388 (Mar 2026) as part of the wholesale
deprecation of the hand-written Java client in favor of the new
openmetadata-sdk module; that forRemoval flag has since shipped
through the 1.13.x and 2.0.x release lines. No HTTP/CLI surface in
the current module exposes this class, so removal carries no in-repo
behavioral change.

The other six files in the module (OpenMetadata gateway,
OpenMetadataAuthenticationProvider, AuthenticationProvider,
AuthenticationProviderFactory, ElasticSearchApi, OktaSSOConfig)
remain in active use and are untouched.

History


Dead Code PRs can be configured here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 2ba1ead1c3fb90db2a0afb6fb09b7201aa587c3e in Playwright run 34070128174, attempt 1.

✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 33m 11s

⏱️ Max setup 2m 56s · max shard execution 5m 23s · max shard-job elapsed before upload 8m 43s · reporting 3s

🌐 146.02 requests/attempt · 1.29 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Application boot ratio was 1.29 per UI scenario (62 boots / 48 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 46 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@detail-app detail-app Bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants