Skip to content

chore: remove dead AnnotationChecker utility - #32777

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-dead-annotationchecker-utility-395b4d
Open

chore: remove dead AnnotationChecker utility#32777
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-dead-annotationchecker-utility-395b4d

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown

Describe your changes

Removed the unused AnnotationChecker class
(common/.../annotations/utils/AnnotationChecker.java) and its test
(AnnotationCheckerTest.java).

Why

The only production caller (ServiceEntityResource.nullifyRequiredConnectionParameters)
was deliberately removed in #13389 ("Separate initialization of Repository and
Resources"); the entire caller method was deleted, not refactored to use something
else. The remaining consumer was AnnotationCheckerTest.java — a test-only consumer
does not count as a production caller. No production code references
isExposedFieldPresent anywhere in the tree. The @ExposedField annotation and its
codegen/runtime machinery (ExposedAnnotator, OnlyExposedFieldAnnotationIntrospector,
JsonUtils.toExposedEntity) are unchanged and remain in use.

Type of change

  • Improvement

High-level design

N/A — small change (deletion of 2 dead files, ~91 lines).

Tests

Removed AnnotationCheckerTest because it only exercised the deleted class.
mvn compile -pl common and mvn test-compile -pl common pass with the deletions.

UI screen recording / screenshots

Not applicable.

History


Dead Code PRs can be configured here.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 8a7a9cd6e374d93436e814f06e1200c81de1edd6 in Playwright run 34070853300, attempt 1.

✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 32m 30s

⏱️ Max setup 3m 3s · max shard execution 5m 28s · max shard-job elapsed before upload 8m 53s · reporting 2s

🌐 146.48 requests/attempt · 1.29 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Application boot ratio was 1.29 per UI scenario (62 boots / 48 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 46 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@detail-app detail-app Bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants