chore: remove dead AnnotationChecker utility - #32777
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 32m 30s ⏱️ Max setup 3m 3s · max shard execution 5m 28s · max shard-job elapsed before upload 8m 53s · reporting 2s 🌐 146.48 requests/attempt · 1.29 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes
Removed the unused
AnnotationCheckerclass(
common/.../annotations/utils/AnnotationChecker.java) and its test(
AnnotationCheckerTest.java).Why
The only production caller (
ServiceEntityResource.nullifyRequiredConnectionParameters)was deliberately removed in #13389 ("Separate initialization of Repository and
Resources"); the entire caller method was deleted, not refactored to use something
else. The remaining consumer was
AnnotationCheckerTest.java— a test-only consumerdoes not count as a production caller. No production code references
isExposedFieldPresentanywhere in the tree. The@ExposedFieldannotation and itscodegen/runtime machinery (
ExposedAnnotator,OnlyExposedFieldAnnotationIntrospector,JsonUtils.toExposedEntity) are unchanged and remain in use.Type of change
High-level design
N/A — small change (deletion of 2 dead files, ~91 lines).
Tests
Removed
AnnotationCheckerTestbecause it only exercised the deleted class.mvn compile -pl commonandmvn test-compile -pl commonpass with the deletions.UI screen recording / screenshots
Not applicable.
History
hostPortfield for some services #6678 @nahuelverdugo)Dead Code PRs can be configured here.