Skip to content

docs: point Playwright test examples to support/fixtures/base - #32774

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-point-playwright-test-examples-to-support-fix-4f3587
Open

docs: point Playwright test examples to support/fixtures/base#32774
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-point-playwright-test-examples-to-support-fix-4f3587

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 6, 2026

Copy link
Copy Markdown

Describe your changes:

Corrected three living Playwright docs whose copy-paste example imports
still pulled test/expect from @playwright/test, the convention
before support/fixtures/base.ts became the suite's single entry point.
The examples now import from the new base fixture module (with each
file's existing relative path), matching the 224 specs migrated in the
source change.

A contributor following the old example would write a spec that
bypasses installServerLoadReducers and the boot-endpoint read-through
cache, silently opting out of the server-load reductions the rest of
the suite relies on — no lint rule enforces the new import source, so
the docs are the only guide.

Introduced by commit 90e9a78 (@pmbrull, #32594)

Type of change:

  • Documentation

High-level design:

N/A — small change.

Tests:

Not applicable — documentation only.

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.

Doc Drift PRs can be configured here.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 0ce2062c2f3e8a170b060d5bfb8f91fae72b4c90 in Playwright run 34070072807, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 51m 26s

⏱️ Max setup 4m 35s · max shard execution 23m 8s · max shard-job elapsed before upload 26m 36s · reporting 5s

🌐 234.72 requests/attempt · 2.82 app boots/UI scenario · 22.41% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 22.41% (convergence target: at most 15%).
  • Browser traffic was 234.72 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 133 0 0 0 0 0
✅ Shard chromium-02 140 0 0 0 0 0
✅ Shard chromium-03 126 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant