Skip to content

docs: drop migrated TeamAndUserSelectItem from Button ref sweep #32768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

docs: drop migrated TeamAndUserSelectItem from Button ref sweep #32768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/antd-migration/button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ triage regardless of which literal mapping is chosen (example:
| `shape="round"` (pill, 1 usage) | GAP — no pill variant. Example: `components/ActivityFeed/Reactions/Emoji.tsx:116` |
| `block` (25 usages, all R1) | `className="tw:w-full"` — mechanical move, but needs visual QA since it's no longer a first-class prop. Example: `components/NotificationBox/NotificationBox.component.tsx:271` |
| `Button.Group` (5 legacy sites: `ClassificationDetails.tsx:1038`, `GlossaryHeader.component.tsx`, `DataProductsDetailsPage.component.tsx`, `GithubStarCard.component.tsx`, `DomainDetails.component.tsx:1038`) | These group **independent action buttons** (vote/star controls), not single-select toggle state. Core `ButtonGroup`/`ButtonGroupItem` is a react-aria `ToggleButtonGroup` (single-select) — semantic mismatch, not a drop-in. Replace with a plain flex row of `Button`s (`className="tw:flex tw:gap-*"`), one per site, by hand. (5 *already-migrated* core `ButtonGroup` usages exist as precedent in R1 lineage components and 2 in R2 — those are genuine toggle groups and are correct as-is; do not touch) |
| `ref={...}` (5 live usages) | core `Button` is now `forwardRef`-wrapped — **landed in main** (ui-core-components). `<Button ref={...}>` passes through directly; these 5 call sites are unblocked and safe to convert. Sites: `components/Alerts/DestinationFormItem/TeamAndUserSelectItem/TeamAndUserSelectItem.tsx:238`, `components/common/AvatarCarouselItem/AvatarCarouselItem.tsx:62`, plus 3 more (see gap-check §1.9/§4.6) |
| `ref={...}` (4 live usages) | core `Button` is now `forwardRef`-wrapped — **landed in main** (ui-core-components). `<Button ref={...}>` passes through directly; these 4 call sites are unblocked and safe to convert. Sites: `components/common/AvatarCarouselItem/AvatarCarouselItem.tsx:62`, plus 3 more (see gap-check §1.9/§4.6) |

## Before / after examples

Expand Down Expand Up @@ -242,7 +242,7 @@ written ones.
- **`Button.Group`** — 5 legacy sites (file:line list above) — semantic
mismatch with core's single-select `ButtonGroup`, redesign per site as a
flex row of `Button`s
- **`ref`** — 5 live usages — unblocked (ui-core-components `forwardRef`
- **`ref`** — 4 live usages — unblocked (ui-core-components `forwardRef`
landed in main); convert directly, per-site
- **`block`** — 25 usages (R1) — mechanical `tw:w-full` move but every site
needs visual QA
Expand Down
Loading