Skip to content

Fixes #32183: render Athena table names without default database - #32630

Queued
atirna wants to merge 2 commits into
open-metadata:mainfrom
atirna:fix/athena-custom-sql-table-name
Queued

Fixes #32183: render Athena table names without default database#32630
atirna wants to merge 2 commits into
open-metadata:mainfrom
atirna:fix/athena-custom-sql-table-name

Conversation

@atirna

@atirna atirna commented Sep 5, 2026

Copy link
Copy Markdown

Describe your changes:

Athena does not use OpenMetadata's placeholder default database segment in SQL identifiers. I now render {{ table_name }} as schema.table for Athena rule-library SQL tests, matching the connector's native identifier shape.

Fixes #32183

Type of change:

  • Bug fix

High-level design:

N/A, small change.

Tests:

Use cases covered

  • An Athena table or column rule renders {{ table_name }} as schema.table.
  • Database-bearing services continue to render database.schema.table.

Unit tests

  • I added unit tests for the new/changed logic.
  • Files updated: ingestion/tests/unit/observability/data_quality/validations/test_rule_library_sql_expression_validator.py

Backend integration tests

  • Not applicable, no backend API changes.

Ingestion integration tests

  • Not applicable, no connector behavior change.

Playwright (UI) tests

  • Not applicable, no UI changes.

Manual testing performed

  1. ruff check on the changed ingestion sources and unit test.
  2. ruff format --check on the changed ingestion sources and unit test.

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes #32183: render Athena table names without the default database
  • My PR is linked to a GitHub issue via Fixes #32183 above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: not applicable, no schema change.
  • For UI changes: not applicable.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

…database

Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
@atirna
atirna requested a review from a team as a code owner September 5, 2026 12:09
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes Athena table name rendering in rule-library SQL tests to use schema.table format instead of including the default database segment. Includes unit tests covering Athena and database-bearing services. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@IceS2
IceS2 requested a review from harshsoni2024 September 8, 2026 08:43
@harshsoni2024 harshsoni2024 added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 8, 2026
@harshsoni2024
harshsoni2024 added this pull request to the merge queue Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Custom SQL Test {{ table_name }} Jinja template injects invalid service prefix for AWS Athena dialect

2 participants