Fixes #32183: render Athena table names without default database - #32630
Fixes #32183: render Athena table names without default database#32630atirna wants to merge 2 commits into
Conversation
…database Signed-off-by: Atirna <288419661+atirna@users.noreply.github.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedFixes Athena table name rendering in rule-library SQL tests to use OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Athena does not use OpenMetadata's placeholder
defaultdatabase segment in SQL identifiers. I now render{{ table_name }}asschema.tablefor Athena rule-library SQL tests, matching the connector's native identifier shape.Fixes #32183
Type of change:
High-level design:
N/A, small change.
Tests:
Use cases covered
{{ table_name }}asschema.table.database.schema.table.Unit tests
ingestion/tests/unit/observability/data_quality/validations/test_rule_library_sql_expression_validator.pyBackend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
ruff checkon the changed ingestion sources and unit test.ruff format --checkon the changed ingestion sources and unit test.UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes #32183: render Athena table names without the default databaseFixes #32183above.