Skip to content

fix(builtin.lsp): discriminate 'from' to fix outgoingCalls resolution#3654

Open
thatnealpatel wants to merge 1 commit intonvim-telescope:masterfrom
thatnealpatel:master
Open

fix(builtin.lsp): discriminate 'from' to fix outgoingCalls resolution#3654
thatnealpatel wants to merge 1 commit intonvim-telescope:masterfrom
thatnealpatel:master

Conversation

@thatnealpatel
Copy link
Copy Markdown

Description

I noticed gopls call_hierarchy ... would produce the expected positional information.

callHierarchy/outgoingCalls resolved incorrect positions for telescope.nvim and neovim.

This should be reproducible for any invocation in any file.

Type of change

Bugfix (non-breaking, I believe).

How Has This Been Tested?

Verified in editor. I did not find existing tests for which to add a case.

See neovim/neovim#39284

Configuration:

NVIM v0.10.4
Build type: Release
LuaJIT 2.1.1713484068
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant