async job finder: correctly handle files not ending in newline#3465
Open
emmanueltouzery wants to merge 1 commit intonvim-telescope:masterfrom
Open
async job finder: correctly handle files not ending in newline#3465emmanueltouzery wants to merge 1 commit intonvim-telescope:masterfrom
emmanueltouzery wants to merge 1 commit intonvim-telescope:masterfrom
Conversation
d790442 to
1c6934d
Compare
1c6934d to
d4b66da
Compare
This was referenced May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2517
Description
The telescope async job runner would not properly handle files without a trailing newline. It would just crash on them.
Fixes #2517
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
git_commandingit_bcommits#2517Configuration:
Checklist: