Skip to content

feat(builtin.marks): add support for cwd and cwd_only options#3324

Open
coockoo wants to merge 1 commit intonvim-telescope:masterfrom
coockoo:marks-cwd
Open

feat(builtin.marks): add support for cwd and cwd_only options#3324
coockoo wants to merge 1 commit intonvim-telescope:masterfrom
coockoo:marks-cwd

Conversation

@coockoo
Copy link
Copy Markdown

@coockoo coockoo commented Oct 10, 2024

Description

This PR allows usage of cwd and cwd_only options in marks picker.

Fixes #3213

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • :lua require('telescope.builtin').marks({ cwd_only = true })
  • :lua require('telescope.builtin').marks({ cwd = '/path/to/cwd' })

Configuration:

  • Neovim version (nvim --version): NVIM v0.10.1
  • Operating system and version: macOS 14.7

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@coockoo coockoo changed the title marks picker: add support for cwd and cwd_only options feat(builtin.marks): add support for cwd and cwd_only options Oct 10, 2024
Copy link
Copy Markdown

@bazko1 bazko1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - works fine I was looking for this options to add to my config.

@cascassette
Copy link
Copy Markdown

Same here, works like a charm and would like this feature in

@cascassette
Copy link
Copy Markdown

I would like to say that this PR works flawlessly, and I would like to add that I would like this functionality to be made available for :Telescope jumplist as well. I've tried some similar code changes, but it doesn't work because jumplist only has bufnrs and no filenames. And get_filename_fn is not available outside of make_entry.lua. Any ideas anybody?

@xeon826
Copy link
Copy Markdown

xeon826 commented Oct 14, 2025

Not trying to be rude or anything but is anyone at the helm on telescope.nvim? I see it's 5 months since the last commit or am I mistaken? Necessary PR here I feel like too.

@cascassette
Copy link
Copy Markdown

@xeon826 feel free to install from my fork https://github.com/cascassette/telescope.nvim instead which has cwd_only options for both marks and jumps

No promises about maintenance or even checking the issues/discussions tho

@xeon826
Copy link
Copy Markdown

xeon826 commented Oct 16, 2025

@xeon826 feel free to install from my fork https://github.com/cascassette/telescope.nvim instead which has cwd_only options for both marks and jumps

No promises about maintenance or even checking the issues/discussions tho

I would but other plugins are looking for telescope.nvim. Again, all due respect, wondering about the status of this very pivotal nvim plugin.

@alerque
Copy link
Copy Markdown

alerque commented Dec 11, 2025

This needs somebody to push the CI allow button here at least. There are two other code reviews making 3 parties using this, and a code review looks sane to me. It should be linted and tested and keep moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cwd_only option for marks picker

5 participants