fix(previewer): improve file_maker line splitting and timeouts#3261
Open
jamestrew wants to merge 1 commit intonvim-telescope:masterfrom
Open
fix(previewer): improve file_maker line splitting and timeouts#3261jamestrew wants to merge 1 commit intonvim-telescope:masterfrom
file_maker line splitting and timeouts#3261jamestrew wants to merge 1 commit intonvim-telescope:masterfrom
Conversation
Contributor
|
@jamestrew rebase? |
jamestrew
force-pushed
the
file-maker-split
branch
from
18a8b8d to
ec72152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous method of splitting files into lines and incorporating a timer is sub-optimal in two ways
By avoiding using
vim.gsplit, we can avoid some overheads it needs to account for patterns and options, and we can check for timeouts more incrementally (every 200 bytes) to avoid getting caught up in huge singular lines.Based on quick and dirty benchmarks against large-ish files in the issue above, I'm seeing about a 4-5x speed increase.