Apply fixes from tooling updates - #2776
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the codebase to align with newer tooling/linting expectations, primarily by standardizing PHP anonymous class instantiation syntax and PHPUnit assertion style, plus relocating two @hasMany directive tests to the integration suite where they better fit.
Changes:
- Normalize anonymous class instantiation style (
new class ...) across tests and service provider binding. - Replace fully-qualified
\PHPUnit\Framework\Assert::...calls with$this->.../self::...assertions where appropriate. - Move
HasManyDirectiveTestcoverage fromtests/Unitintotests/Integration(and add the required imports).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Subscriptions/SubscriptionTest.php | Anonymous class syntax update in subscription registration test. |
| tests/Unit/Subscriptions/BroadcastDriverManagerTest.php | Anonymous class syntax update and PHPUnit assertion style normalization. |
| tests/Unit/Scout/ScoutEnhancerTest.php | Anonymous class syntax updates for directive fixtures. |
| tests/Unit/Schema/Directives/ThrottleDirectiveTest.php | Anonymous class syntax update for CreatesContext test double. |
| tests/Unit/Schema/Directives/HasManyDirectiveTest.php | Removes unit-level @hasMany tests (moved to integration). |
| tests/Unit/Schema/Directives/BaseDirectiveTest.php | Anonymous class syntax update for directive fixture. |
| tests/Unit/Schema/DirectiveLocatorTest.php | Anonymous class syntax update for directive fixture. |
| tests/Unit/Schema/AST/ASTHelperTest.php | Anonymous class syntax updates for directive fixtures. |
| tests/Unit/Schema/AST/ASTBuilderTest.php | Anonymous class syntax updates for directive fixtures. |
| tests/Unit/Execution/ResolveInfoTest.php | Anonymous class syntax updates for directive fixtures and ResolveInfo test double. |
| tests/Unit/Execution/CreatesContextTest.php | Anonymous class syntax update and assertion style normalization inside resolver mock. |
| tests/Unit/Auth/CanRootDirectiveTest.php | Anonymous class syntax update for return object fixture. |
| tests/Unit/Auth/CanResolvedDirectiveTest.php | Anonymous class syntax update for return object fixture. |
| tests/TestsSerialization.php | Anonymous class syntax updates for context serializer and context fixtures. |
| tests/Integration/Schema/Directives/MorphToManyDirectiveTest.php | PHPUnit assertion style normalization. |
| tests/Integration/Schema/Directives/HasManyDirectiveTest.php | Adds the moved @hasMany integration tests and necessary imports. |
| tests/Integration/Schema/Directives/AggregateDirectiveTest.php | PHPUnit assertion style normalization inside static factory callback. |
| tests/Integration/Execution/DataLoader/PaginatedRelationLoaderTest.php | PHPUnit assertion style normalization for loaded model assertions. |
| src/LighthouseServiceProvider.php | Anonymous class syntax update for default subscription resolver binding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.