Skip to content

Apply fixes from tooling updates - #2776

Merged
spawnia merged 1 commit into
masterfrom
apply-tooling-updates
Jun 29, 2026
Merged

Apply fixes from tooling updates#2776
spawnia merged 1 commit into
masterfrom
apply-tooling-updates

Conversation

@spawnia

@spawnia spawnia commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the codebase to align with newer tooling/linting expectations, primarily by standardizing PHP anonymous class instantiation syntax and PHPUnit assertion style, plus relocating two @hasMany directive tests to the integration suite where they better fit.

Changes:

  • Normalize anonymous class instantiation style (new class ...) across tests and service provider binding.
  • Replace fully-qualified \PHPUnit\Framework\Assert::... calls with $this->... / self::... assertions where appropriate.
  • Move HasManyDirectiveTest coverage from tests/Unit into tests/Integration (and add the required imports).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Unit/Subscriptions/SubscriptionTest.php Anonymous class syntax update in subscription registration test.
tests/Unit/Subscriptions/BroadcastDriverManagerTest.php Anonymous class syntax update and PHPUnit assertion style normalization.
tests/Unit/Scout/ScoutEnhancerTest.php Anonymous class syntax updates for directive fixtures.
tests/Unit/Schema/Directives/ThrottleDirectiveTest.php Anonymous class syntax update for CreatesContext test double.
tests/Unit/Schema/Directives/HasManyDirectiveTest.php Removes unit-level @hasMany tests (moved to integration).
tests/Unit/Schema/Directives/BaseDirectiveTest.php Anonymous class syntax update for directive fixture.
tests/Unit/Schema/DirectiveLocatorTest.php Anonymous class syntax update for directive fixture.
tests/Unit/Schema/AST/ASTHelperTest.php Anonymous class syntax updates for directive fixtures.
tests/Unit/Schema/AST/ASTBuilderTest.php Anonymous class syntax updates for directive fixtures.
tests/Unit/Execution/ResolveInfoTest.php Anonymous class syntax updates for directive fixtures and ResolveInfo test double.
tests/Unit/Execution/CreatesContextTest.php Anonymous class syntax update and assertion style normalization inside resolver mock.
tests/Unit/Auth/CanRootDirectiveTest.php Anonymous class syntax update for return object fixture.
tests/Unit/Auth/CanResolvedDirectiveTest.php Anonymous class syntax update for return object fixture.
tests/TestsSerialization.php Anonymous class syntax updates for context serializer and context fixtures.
tests/Integration/Schema/Directives/MorphToManyDirectiveTest.php PHPUnit assertion style normalization.
tests/Integration/Schema/Directives/HasManyDirectiveTest.php Adds the moved @hasMany integration tests and necessary imports.
tests/Integration/Schema/Directives/AggregateDirectiveTest.php PHPUnit assertion style normalization inside static factory callback.
tests/Integration/Execution/DataLoader/PaginatedRelationLoaderTest.php PHPUnit assertion style normalization for loaded model assertions.
src/LighthouseServiceProvider.php Anonymous class syntax update for default subscription resolver binding.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spawnia
spawnia merged commit d909fb2 into master Jun 29, 2026
94 checks passed
@spawnia
spawnia deleted the apply-tooling-updates branch June 29, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants