Skip to content

components: allow title clicks to toggle page tree #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bschaatsbergen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

components: allow title clicks to toggle page tree #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b776e
components: allow title clicks to toggle page tree
bschaatsbergen Jun 1, 2025
46c5e20
components: improve navigation UX in SubLink component
bschaatsbergen Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions nextjs-base/components/sublink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { cn } from "@/lib/utils";
import { SheetClose } from "@/components/ui/sheet";
import { ChevronDown, ChevronRight } from "lucide-react";
import { useEffect, useState } from "react";
import { usePathname } from "next/navigation";
import { usePathname, useRouter } from "next/navigation";

export default function SubLink({
title,
Expand All @@ -21,16 +21,31 @@ export default function SubLink({
tag,
}: EachRoute & { level: number; isSheet: boolean }) {
const path = usePathname();
const router = useRouter();
const [isOpen, setIsOpen] = useState(level == 0);

useEffect(() => {
if (path == href || path.includes(href)) setIsOpen(true);
}, [href, path]);

const handleClick = (e: React.MouseEvent) => {
e.preventDefault();
e.stopPropagation();

// Toggle collapsible if has items
if (items && items.length > 0) {
setIsOpen(!isOpen);
}

// Always navigate to the page
router.push(href);
};

const Comp = (
<Anchor
activeClassName="text-primary dark:font-medium font-semibold"
href={href}
onClick={handleClick}
>
{title}
{tag && (
Expand Down Expand Up @@ -65,8 +80,8 @@ export default function SubLink({
return (
<div className="flex flex-col gap-1 w-full">
<Collapsible open={isOpen} onOpenChange={setIsOpen}>
<CollapsibleTrigger className="w-full pr-5">
<div className="flex items-center justify-between cursor-pointer w-full">
<CollapsibleTrigger asChild>
<div className="flex items-center justify-between cursor-pointer w-full pr-5">
<span className="w-[95%] overflow-hidden text-ellipsis text-start">
{titleOrLink}
</span>
Expand Down