Update release.yml to remove NPM_TOKEN - #451
Open
HarshTyagi8010 wants to merge 1 commit into
Open
Conversation
Removed NPM_TOKEN from semantic-release environment.
Author
|
Fix npm tokens |
clark-cant
reviewed
Aug 20, 2026
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
Metadata-First Review Summary
PR: #451 — Update release.yml to remove NPM_TOKEN
Author: @HarshTyagi8010
Size: +0/-2 (1 file)
mergeStateStatus: CLEAN
mergeable: MERGEABLE
reviewDecision: (none yet)
Change Analysis
This PR removes two lines from .github/workflows/release.yml:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}env var-p @semantic-release/npmplugin
This effectively disables npm publishing from the semantic-release workflow.
Context
Related to #215 where @luantaraschi documented that uipro-cli on npm is stale (last published 2026-01-29) while development moved to ui-ux-pro-max-cli. This change may be intentional cleanup, but it's a significant CI/CD decision that needs maintainer confirmation.
Decision: Needs Maintainer Approval
- Cannot merge without explicit maintainer sign-off
- The change is valid but has downstream implications for release workflow
- @zuey or maintainers: please confirm if npm publishing should be fully removed
Posted by github-maintain cron
clark-cant
requested changes
Aug 23, 2026
clark-cant
left a comment
Contributor
There was a problem hiding this comment.
Request changes\n\nRemoving @semantic-release/npm disables the repository’s configured npm publish step: .releaserc.json still declares that plugin with pkgRoot: cli, and the release workflow is the place that installs/runs the semantic-release plugins. Removing NPM_TOKEN is only valid if this PR also changes the release strategy/config to intentionally stop npm publishing and documents the replacement.\n\nPlease either retain @semantic-release/npm and its required token, or include a complete, tested migration to another publishing mechanism.\n\nMandatory gates: duplicate/prior work checked (release PRs #375/#384/#393); project standards checked (CLAUDE.md); strategic necessity is not justified because the change breaks the npm release path.\n\nPosted by github-maintain cron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed NPM_TOKEN from semantic-release environment.
What does this PR change?
Why?
Checklist
src/ui-ux-pro-max/(source of truth), not directly in.claude/or.factory/npm run sync:assets && npm run check:assetsincli/if data/scripts/templates changed.claude/skills/*/scripts/tests/,cli/tests/e2e/)feat:,fix:,docs:, etc.)main