Add motion domain and design dials (variance/motion/density)

[Abraham040203]

Summary

• Adds a new searchable motion domain (data/motion.csv, 16 GSAP animation skeletons across hover / scroll-reveal / stagger-list / page-transition / parallax / loading, each tagged Subtle/Standard/Complex)
• Adds three optional 1-10 dials on --design-system: --variance, --motion, --density (inspired by taste-skill's DESIGN_VARIANCE/MOTION_INTENSITY/VISUAL_DENSITY sliders), documented in CLAUDE.md, templates/base/skill-content.md, and the compiled SKILL.md
  • --variance biases style search/selection toward centered-minimal (low) or bold-asymmetric (high)
  • --motion attaches a matching GSAP snippet (code + framework notes + do/don't + perf notes) from motion.csv
  • --density overrides the --space-* token scale in ASCII/markdown/MASTER.md output
• All three dials are optional and purely additive — verified via regression diff that output with no dials set is byte-identical to before this change
• Synced the same feature into .claude/skills/ui-ux-pro-max/ and cli/assets/ so the installed skill and publishable CLI package stay consistent with src/ui-ux-pro-max/ (source of truth)
• Second commit separately catches up pre-existing cli/assets drift from src (unrelated to this feature, found while running the project's own sync-assets.mjs)

Test plan

• python3 src/ui-ux-pro-max/scripts/search.py "<query>" --domain motion -n 2 returns well-formed GSAP snippets
• --design-system with no dials produces byte-identical output to pre-change baseline (diffed)
• --design-system --variance N --motion N --density N (low/mid/high combinations) produces expected tier selection, motion snippet, and spacing scale
• --persist with dials renders "Design Dials" + "Motion" sections and overridden spacing table in MASTER.md
• Verified identical behavior across all three copies: src/ui-ux-pro-max, .claude/skills/ui-ux-pro-max, cli/assets
• node cli/scripts/sync-assets.mjs --check reports assets in sync
• Out-of-range dial values (e.g. --variance 15) rejected with a clear argparse error

[clark-cant]

🤖 github-maintain cron review

Summary: Adds a motion search domain (16 GSAP animation skeletons) and three optional design dials (--variance, --motion, --density) to the design system generator. Also registers 6 new desktop/framework stacks (javafx, wpf, winui, avalonia, uno, uwp) and catches up cli/assets drift.

Risk level: Medium — well-structured feature addition, but touches core search, design system generation, and BM25 tokenizer behavior across all three distribution copies.

Mandatory gates:

• Duplicate/prior implementation: overlap found — PR feat(data): add motion-principles domain (Emil Kowalski) #296 (feat/emil-motion-principles) also registers a motion domain in core.py CSV_CONFIG and detect_domain with 37 Emil Kowalski motion principles. This PR's motion.csv (16 GSAP skeletons) covers a different angle (code snippets vs design principles), so they are complementary rather than duplicate — but both register the same motion key in CSV_CONFIG and detect_domain. If both merge independently, one will overwrite the other's domain registration. These PRs need coordination.
• Project standards: docs found — CLAUDE.md source-of-truth pattern followed; src/, .claude/skills/, and cli/assets/ all updated consistently.
• Strategic necessity: clear value — GSAP animation skeletons with intensity tiers are a genuinely useful addition for the design system workflow.

Findings:

• Important: Motion domain collision with PR feat(data): add motion-principles domain (Emil Kowalski) #296. Both PRs add "motion" to CSV_CONFIG. Please coordinate with @najamali — either merge one first and have the other adapt, or combine the motion domains into a single registration that serves both use cases.
• Important: The BM25 tokenizer change (len(w) > 2 → len(w) >= 2) is a behavior change that affects all search results, not just the new motion domain. This is actually the same fix requested in PR fix: path traversal guards, asset ifix: path traversal guards, ZIP integrity check, --max-length flag, engines field, testsntegrity, max-length flag, engines… #348's test failure. Consider calling this out explicitly in the PR description or separating it into its own commit with a note about the cross-domain impact.
• Suggestion: The 6 new stack registrations (javafx, wpf, winui, avalonia, uno, uwp) are unrelated to the motion/dials feature. Consider splitting into a separate PR for cleaner review history.
• Suggestion: The sys.stdout UTF-8 wrapper in design_system.py is a good Windows fix but should be documented in the PR description.

Verdict: Comment — valuable feature, but needs coordination with PR #296 on the motion domain registration before merge.

---

Posted by github-maintain cron at 2026-07-02T00:23:00Z

[Abraham040203]

Thanks for catching the collision with #296 — fixed in the latest commit.

Renamed this PR's domain from motion to gsap (CSV_CONFIG key, detect_domain keywords, and the internal lookup in design_system.py). This PR's motion.csv is GSAP-specific implementation code, so gsap is arguably a more accurate name anyway; motion-principles.csv in #296 can keep the motion key for the broader design-principle rules.

Note the --motion CLI dial (--variance/--motion/--density on --design-system) is unrelated to this and unchanged — only the --domain <name> search key was renamed. Re-verified no regressions: --design-system with no dials set is still byte-identical to pre-PR output.

The other two items were "Suggestion" level, not blocking, but for the record: the extra stack registrations (javafx/wpf/winui/avalonia/uno/uwp) and the BM25 tokenizer fix (> 2 → >= 2) were pre-existing gaps between src/ and .claude/skills//cli/assets/ that I picked up while syncing this feature into all three copies — already isolated in a separate commit ("Sync cli/assets with src (catch up pre-existing drift)") from the actual feature commit.

[clark-cant]

✅ Approved — Collision resolved

Summary: Adds motion domain (16 GSAP skeletons) and three optional design dials (--variance, --motion, --density). Well-structured feature with proper source-of-truth sync across src/, .claude/skills/, and cli/assets/.

Collision fix verified: ✅

• Domain renamed from motion → gsap in CSV_CONFIG, detect_domain, and search.py
• --motion CLI dial unchanged (correctly decoupled from domain key)
• motion.csv file name retained but registered under gsap domain
• No collision with PR #296's Emil Kowalski motion-principles domain

Quality notes:

• Clean separation: GSAP implementation code (this PR) vs design principles (#296)
• BM25 tokenizer fix (> 2 → >= 2) is a good cross-domain improvement
• Windows UTF-8 stdout wrapper is a nice touch
• All three distribution copies kept in sync

Verdict: Approve — ready to merge.

---

Posted by github-maintain cron at $(date -u +"%Y-%m-%dT%H:%M:%SZ")