feat(copilot): add VS Code Copilot skill compatibility and docs - #241
feat(copilot): add VS Code Copilot skill compatibility and docs#241hatimbenayad wants to merge 1 commit into
Conversation
- mirror skill packs from .claude/skills to .github/skills for Copilot discovery - normalize copied skill metadata and path references for .github layout - add workspace-level Copilot instructions at .github/copilot-instructions.md - document manual GitHub Copilot setup in README
|
Cron-safe maintainer pass: deferring this PR from the bounded review lane because it is too large for a safe metadata-first run (189 files, +22,246/-0) and GitHub cannot even serve the full diff through the normal diff API. Please narrow this into focused PRs before maintainer review:
Acceptance bar for a future review: explain why |
Stale content — needs rebase to sync with recent path-portability fixesThis PR mirrors skills to
The mirrored copies in Required before merge:
The strategic value is clear — Copilot support is a legitimate platform target. But the mirror needs to stay in sync with the source of truth, especially after infrastructure fixes like these. Status: Requesting rebase/update. Will re-review once the branch reflects current main. Posted by github-maintain cron |
clark-cant
left a comment
There was a problem hiding this comment.
Review: feat(copilot): add VS Code Copilot skill compatibility and docs
Summary: This PR mirrors the entire .claude/skills/ tree into .github/skills/ for GitHub Copilot skill discovery, adds workspace-level Copilot instructions, and updates the README.
Risk level: Medium — large surface area (189 files, +22,246 lines), but additive-only (0 deletions) and structurally mechanical.
Mandatory Gates
-
Duplicate / prior implementation: Partial overlap. PR #17 (merged) added Copilot CLI support via
.github/prompts/. PR #328 (merged) added.prompt.mdgeneration. This PR takes a different approach — placing skills directly in.github/skills/for native Copilot discovery. Issue #454 explicitly requests this direction ("Skills instead of Prompts"). Not a duplicate, but the relationship between the two approaches (prompts vs. skills) should be documented. -
Project standards: No formal standards doc found. Reviewing against observed patterns: the repo maintains skills under
.claude/skills/with a consistent structure. This PR preserves that structure in the new location. -
Strategic necessity: Clear value — Issue #454 has been open since Aug 2023 requesting Copilot skill support. This PR delivers it.
Findings
Important:
-
Maintenance burden — 22K lines of mirrored content. Every future change to a skill file must now be made in two places. There is no sync script, no CI check, and no documentation about this requirement. This will drift.
Suggested fix (pick one):
- Add a
scripts/sync-skills-to-github.shthat copies.claude/skills/→.github/skills/and wire it into the release workflow - Or: add a CI check that diffs the two trees and fails if they diverge
- Or: at minimum, add a
CONTRIBUTING.mdnote explaining the dual-location requirement
- Add a
-
No link to Issue #454. Please add
Closes #454(orPartial fix for #454) to the PR body so the issue is tracked.
Suggestion:
- The
.github/copilot-instructions.mdfile is good but brief. Consider linking to the Copilot skills documentation for discoverability.
Verdict: Request Changes
The approach is sound and addresses a real need, but the 22K-line mirror without a sync mechanism creates a maintenance trap. One of the three fixes above (sync script, CI check, or documented manual process) is needed before merge.
Posted by github-maintain automation at $(date -u +'%Y-%m-%dT%H:%M:%SZ')
mirror skill packs from .claude/skills to .github/skills for Copilot discovery
normalize copied skill metadata and path references for .github layout
add workspace-level Copilot instructions at .github/copilot-instructions.md
document manual GitHub Copilot setup in README