fix(FindAllResources): handle single-object responses without panic#106
Open
writesz wants to merge 1 commit intonetscaler:mainfrom
Open
fix(FindAllResources): handle single-object responses without panic#106writesz wants to merge 1 commit intonetscaler:mainfrom
writesz wants to merge 1 commit intonetscaler:mainfrom
Conversation
The NITRO API returns a JSON array for most resource types, but some
(e.g. nsversion) return a single JSON object. The hard type assertion
on line 740:
resources := data[resourceType].([]interface{})
panics with "interface conversion: interface {} is map[string]interface {},
not []interface {}" when the value is a plain object.
Replace the assertion with a type switch that handles:
- []interface{} → existing array path (unchanged behaviour)
- map[string]interface{} → wrap in a single-element slice
- anything else → return empty slice with a warning log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NITRO API returns a JSON array for most resource types, but some (e.g. nsversion) return a single JSON object. The hard type assertion on line 740:
panics with "interface conversion: interface {} is map[string]interface {}, not []interface {}" when the value is a plain object.
Replace the assertion with a type switch that handles: