Skip to content

fix(tls): add legacy RSA cipher suites for older NetScaler firmware #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
writesz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tls): add legacy RSA cipher suites for older NetScaler firmware #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion service/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,19 @@ func NewNitroClientFromParams(params NitroParams) (*NitroClient, error) {
} else {
tr := &http.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
InsecureSkipVerify: true, //nolint:gosec
// Include legacy RSA key-exchange cipher suites for compatibility with
// older NetScaler/ADC firmware. Go 1.22+ removed these from the default
// set (see https://go.dev/doc/go1.22#crypto/tls), which causes a TLS
// handshake failure against appliances that only support e.g. AES256-SHA.
CipherSuites: []uint16{
tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
tls.TLS_RSA_WITH_AES_256_CBC_SHA,
tls.TLS_RSA_WITH_AES_128_CBC_SHA,
},
},
Proxy: http.ProxyFromEnvironment,
}
Expand Down