Skip to content

style: PHP CS Fixer#2725

Merged
DjordyKoert merged 1 commit into5.xfrom
style-fix
Apr 13, 2026
Merged

style: PHP CS Fixer#2725
DjordyKoert merged 1 commit into5.xfrom
style-fix

Conversation

@DjordyKoert
Copy link
Copy Markdown
Collaborator

Description

Fixes failing CI

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)

Copilot AI review requested due to automatic review settings April 13, 2026 07:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.68%. Comparing base (212d490) to head (a6f99d5).
⚠️ Report is 1 commits behind head on 5.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              5.x    #2725   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          94       94           
  Lines        3079     3079           
=======================================
  Hits         2946     2946           
  Misses        133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies PHP-CS-Fixer-driven formatting changes across source and test fixtures to resolve CI style failures.

Changes:

  • Removed declare(strict_types=1); headers from a set of PHP files to match the repository’s prevailing style.
  • Added explicit : void return types to fixture/controller methods that do not return values.

Reviewed changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/RouteDescriber/RouteArgumentDescriber/SymfonyMapRequestPayloadDescriberTest.php Removed strict_types declaration for style consistency.
tests/RouteDescriber/RouteArgumentDescriber/fixture/SomeObject.php Removed strict_types declaration for style consistency.
tests/ModelDescriber/Annotations/Fixture/CompoundValidationRule.php Removed strict_types declaration for style consistency.
tests/ModelDescriber/Annotations/Fixture/CompoundStub.php Removed strict_types declaration for style consistency.
tests/Functional/ModelDescriber/NameConverter.php Removed strict_types declaration for style consistency.
tests/Functional/EntityExcluded/Symfony7/SerializedNameEntity.php Added : void return type to setter method.
tests/Functional/Entity/User.php Added : void return types to multiple setter methods.
tests/Functional/Entity/SymfonyMapQueryString.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/RangeInteger.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/QueryModel/SortQueryModel.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/QueryModel/SortEnum.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/QueryModel/PaginationQueryModel.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/QueryModel/FilterQueryModel.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/QueryModel/ArrayQueryModel.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/PrivateProtectedExposure.php Added : void return type to protected method.
tests/Functional/Entity/JMSUser.php Added : void return types to methods lacking explicit returns.
tests/Functional/Entity/JMSIgnoredProperty.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/GenericTypes.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/EntityWithIgnoredProperty.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/Article.php Added : void return types to setter methods.
tests/Functional/Entity/ArrayItems/Dictionary.php Removed strict_types declaration for style consistency.
tests/Functional/Entity/ArrayItems/Bar.php Added : void return type to method.
tests/Functional/Controller/UndocumentedController.php Added : void return type to controller action.
tests/Functional/Controller/SecuredApiController.php Added : void return types to controller actions.
tests/Functional/Controller/PromotedPropertiesController81.php Removed strict_types declaration for style consistency.
tests/Functional/Controller/OperationIdController.php Removed strict_types declaration for style consistency.
tests/Functional/Controller/OpenApiTagController.php Removed strict_types and added : void return types to actions.
tests/Functional/Controller/MapUploadedFileController.php Added : void return types to controller actions.
tests/Functional/Controller/MapRequestPayloadController.php Added : void return types to controller actions.
tests/Functional/Controller/MapQueryStringController.php Removed strict_types and added : void return types to actions.
tests/Functional/Controller/MapQueryParameterController.php Added : void return types to controller actions.
tests/Functional/Controller/InvokableController.php Added : void return type to __invoke().
tests/Functional/Controller/GenericTypesController.php Removed strict_types declaration for style consistency.
tests/Functional/Controller/Controller2209.php Removed strict_types declaration for style consistency.
tests/Functional/Controller/ClassApiController.php Added : void return type to controller action.
tests/Functional/Controller/ApiController.php Added : void return types to multiple controller actions.
tests/Functional/ConfigurableContainerFactory.php Removed strict_types declaration for style consistency.
src/TypeDescriber/TemplateDescriber.php Removed strict_types declaration for style consistency.
src/TypeDescriber/GenericCollectionDescriber.php Removed strict_types declaration for style consistency.
src/TypeDescriber/GenericClassDescriber.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber/SymfonyMapUploadedFileDescriber.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber/SymfonyMapRequestPayloadDescriber.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber/SymfonyMapQueryStringDescriber.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber/SymfonyMapQueryParameterDescriber.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber/RouteArgumentDescriberInterface.php Removed strict_types declaration for style consistency.
src/RouteDescriber/RouteArgumentDescriber.php Removed strict_types declaration for style consistency.
src/PropertyDescriber/PropertyDescriber.php Removed strict_types declaration for style consistency.
src/Processor/NullablePropertyProcessor.php Removed strict_types declaration for style consistency.
src/Processor/MapRequestPayloadProcessor.php Removed strict_types declaration for style consistency.
src/Processor/MapQueryStringProcessor.php Removed strict_types declaration for style consistency.
src/Attribute/Ignore.php Removed strict_types declaration for style consistency.

@DjordyKoert DjordyKoert merged commit 6e632d6 into 5.x Apr 13, 2026
46 checks passed
@DjordyKoert DjordyKoert deleted the style-fix branch April 13, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants