Skip to content

Moved the elastic facade init before postFacadeInit call #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puru-khedre wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved the elastic facade init before postFacadeInit call #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions framework/src/main/groovy/org/moqui/impl/context/ExecutionContextFactoryImpl.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,15 @@ class ExecutionContextFactoryImpl implements ExecutionContextFactory {
screenFacade = new ScreenFacadeImpl(this)
logger.info("Screen Facade initialized")

postFacadeInit()

// NOTE: ElasticFacade init after postFacadeInit() so finds embedded from moqui-elasticsearch if present, can move up once moqui-elasticsearch deprecated
/**
* NOTE: Moved ElasticFacade init before postFacadeInit() as the moqui-elasticsearch component is not being used.
* Before this change, the ElasticFacade was initialized after the postFacadeInit() method.
*/
elasticFacade = new ElasticFacadeImpl(this)
logger.info("Elastic Facade initialized")

postFacadeInit()

logger.info("Execution Context Factory initialized in ${(System.currentTimeMillis() - initStartTime)/1000} seconds")
}

Expand Down Expand Up @@ -294,12 +297,15 @@ class ExecutionContextFactoryImpl implements ExecutionContextFactory {
screenFacade = new ScreenFacadeImpl(this)
logger.info("Screen Facade initialized")

postFacadeInit()

// NOTE: ElasticFacade init after postFacadeInit() so finds embedded from moqui-elasticsearch if present, can move up once moqui-elasticsearch deprecated
/**
* NOTE: Moved ElasticFacade init before postFacadeInit() as the moqui-elasticsearch component is not being used.
* Before this change, the ElasticFacade was initialized after the postFacadeInit() method.
*/
elasticFacade = new ElasticFacadeImpl(this)
logger.info("Elastic Facade initialized")

postFacadeInit()

logger.info("Execution Context Factory initialized in ${(System.currentTimeMillis() - initStartTime)/1000} seconds")
}

Expand Down