You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before (Discord set to ja-JP: zh-CN, zh-TW, and ko-KR render incorrectly):
Before (Discord set to zh-CN: ja-JP, zh-TW, and ko-KR render incorrectly):
Before (Discord set to ko-KR: ja-JP, zh-CN, and zh-TW render incorrectly):
After:
This code needs to be triple-checked that it's not doing something horrible / obviously-wrong. A lot of the stuff that got this to the finish line feels really hacky / I shouldn't be doing it, so I'd like another set of eyes.
node.ts seems redundant and would just introduce context bridge microlatency since you're just relying on the bundler to read the provided files anyways.
The stylesheet is a little bit horror, but its fine even if it will break themes a tiny bit.
Yeah unfortunately I can't figure out any way to propagate the value in :root:lang(...). inherit as the default font-family for span inherits var(--primary-font) from something that gets the variable from :root, so just redefining it doesn't work/shadow it :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (Discord set to ja-JP: zh-CN, zh-TW, and ko-KR render incorrectly):
Before (Discord set to zh-CN: ja-JP, zh-TW, and ko-KR render incorrectly):
Before (Discord set to ko-KR: ja-JP, zh-CN, and zh-TW render incorrectly):
After:
This code needs to be triple-checked that it's not doing something horrible / obviously-wrong. A lot of the stuff that got this to the finish line feels really hacky / I shouldn't be doing it, so I'd like another set of eyes.