You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace three broken cross-page fragment links in docs/mcp-elements.md with canonical published guide URLs.
Keep the same target sections while making the links work in both GitHub Markdown and generated documentation.
Why
phpDocumentor does not resolve Markdown paths that include fragments, so the generated links disappear. Canonical absolute URLs preserve the fragments without changing the documentation layout.
Impact
Documentation-only change; no runtime behavior is affected.
Unfortunately absolute links break the experience in GitHub - I think unless the upstream issue is not solved and we don't switch to RST, we'd need to switch the tooling 🤔
Agreed — absolute published URLs are not the right fix because they degrade the GitHub browsing experience.
I reproduced the underlying page.md#fragment failure on the latest phpDocumentor/guides main using this SDKs actual mcp-elements.md → server-builder.md#... links. The upstream fix is phpDocumentor/guides#1300. I refreshed it onto current main, confirmed PHP 8.5 lowest dependencies and the full locked suite pass, and added regression coverage for the PHP SDK link shape. Since I cannot update the contributor branch directly, the clean mergeable refresh is at jonathanhefner/phpDocumentor-guides#2.
I am closing this workaround in favor of the upstream fix. Issue #232 should remain open until that fix is merged and available to the docs build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentationneeds confirmationNeeds confirmation that the PR is actually required or needed.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/mcp-elements.mdwith canonical published guide URLs.Why
phpDocumentor does not resolve Markdown paths that include fragments, so the generated links disappear. Canonical absolute URLs preserve the fragments without changing the documentation layout.
Impact
Documentation-only change; no runtime behavior is affected.
Checks
make docsCloses #232