fix: move secrets to env blocks, remove env dump, pin actions [E-1815]#9
Merged
jonathansantilli merged 1 commit intomainfrom Apr 8, 2026
Merged
fix: move secrets to env blocks, remove env dump, pin actions [E-1815]#9jonathansantilli merged 1 commit intomainfrom
jonathansantilli merged 1 commit intomainfrom
Conversation
Security fix for secret exposure and hardening (CWE-78).
Changes:
- Move cx-api-token from command line to env var (was visible in process table)
- Move github-token from curl command line to env var
- Move all ${{ inputs.* }} from run: blocks to env: blocks
- Remove bare `env` command that dumped all secrets to logs
- Replace bash -l {0} with bash
- Quote all variable expansions
- Pin all action references to immutable commit SHAs:
- actions/setup-node v3.6.0 -> v4.4.0 (SHA pinned)
- actions/checkout v3 -> v4.3.1 (SHA pinned)
- guibranco/github-status-action-v2 v1.1.13 (SHA pinned)
The action interface (inputs/outputs) is unchanged — this fix is
transparent to consumers.
Ref: E-1815
Kirill89
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cx-api-tokenfrom command line argument to env var (was visible in process table)github-tokenfrom curl command line to env var${{ inputs.* }}fromrun:blocks toenv:blocksenvcommand that dumped all secrets to workflow logsbash -l {0}withbashSecurity Context
Line 71 (
./cx configure set --prop-name cx_apikey --prop-value ${{ inputs.cx-api-token }}) places the Checkmarx API key directly on the command line, where it is visible in process listings. Line 74 (env) dumps all environment variables (potentially including secrets) to the workflow log.The fix passes all secrets through
env:blocks and removes theenvdebug command.Consumer Impact
None. The action
inputs:andoutputs:are unchanged. This fix is transparent to all consumers.Test plan
The injection test evidence is documented in detail at: mobb-dev/action#31 (comment)