fix(nitrogen): preserve ULong callbacks across JNI - #1632
Open
mrousavy wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
force-pushed
the
fix/kotlin-ulong-callbacks
branch
from
September 7, 2026 19:20
f11f316 to
ab0ed38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin mangles callback methods that use
ULong, so the generated JNI lookup and native registration cannot resolve their names. Add aninvoke_jniadapter with a stable name and useLongonly inside the JNI bridge. The Kotlin API remains(ULong) -> ULong, and conversions preserve all 64 bits, including values aboveLong.MAX_VALUE.This follows #1591, which is now merged. This PR targets
mainand includes the unsigned callback E2E tests and their generated bindings. Long/void coverage and the primitive boxing simplification were merged in #1591.Validation:
ULong.MAX_VALUEon both C++ and Kotlin backends.mainafter fix(nitrogen): look up Kotlin callbacks with a boxed return type聽#1591 merged;git range-diffconfirms the ULong patch is unchanged.