Allow creating a chore without an NFC tag - #112
Open
mapgie wants to merge 2 commits into
Open
Conversation
The New chore sheet disabled Save unless the NFC Tag ID field was filled in, even though a chore doesn't require a physical tag. Since tags.tag_id is NOT NULL UNIQUE in the schema, blank tagIds can't just be allowed through as-is: generate a random unique id when the field is left blank instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nj7xhk7ArLoNwnFNSxnmXG
mapgie
marked this pull request as ready for review
September 3, 2026 17:45
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nj7xhk7ArLoNwnFNSxnmXG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "chore creation without tags" bug: the New chore sheet disabled Save unless the NFC "Tag ID" field was filled in, forcing users to invent a fake tag ID just to create a chore that has no physical NFC tag.
EditChoreSheet.kt:canSavenow only requires a label, nottagId.ChoreListViewModel.addChore: whentagIdis left blank, generates a random unique id (UUID.randomUUID(), same pattern asReminderRepository.addReminder) before creating the chore. This is needed becausetags.tag_idisNOT NULL UNIQUEin the Supabase schema — a chore is stored as a row in thetagstable, so simply relaxing the UI check would fail at insert time for a blank/duplicatetag_id.LESSONS.mdentry documenting the schema constraint so a future "just remove this required-field check" doesn't hit the same DB-layer failure.patch, backward-compatible bug fix).Test plan
a11y_check.py(run locally, no violations).🤖 Generated with Claude Code
https://claude.ai/code/session_01Nj7xhk7ArLoNwnFNSxnmXG
Generated by Claude Code