Use Powerline Segment class instead of the old Powerline function interface - #7
Open
madhurjain2095 wants to merge 1 commit into
Open
madhurjain2095 wants to merge 1 commit into
madhurjain2095 wants to merge 1 commit into
Conversation
…nt` Base class, instead of the old Powerline function interface. 2. Combined the two functions `mem_usage` and `mem_usage_percent` into a single class `MemUsageSegment` and exposed a single object of that class. 3. Added documentation on how the parameters are used. 4. Updated README.md to reflect the new refactored implementation.
Author
|
Inspired from powerline-gitstatus and powerline-docker (both of which I use) |
Owner
|
Hi, thanks for this - looks good to me. |
Author
|
Hey, apologies for the delay in response (was busy with my courses) Yeah, IMO I think it's better to move forward with the new design as per Powerline documents, and as such, reduce the technical debt that occurs with staying with the old version. Other than that, I don't think there's any other clear advantage with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mem_usageandmem_usage_percentinto a single classMemUsageSegmentand exposed a single object of that class.