Fix Base.empty!(::GenericModel) and document its troublesome behavior - #4237
Open
odow wants to merge 1 commit into
Open
Fix Base.empty!(::GenericModel) and document its troublesome behavior#4237odow wants to merge 1 commit into
odow wants to merge 1 commit into
Conversation
odow
commented
Sep 3, 2026
|
|
||
| julia> x === y | ||
| true | ||
| ``` |
Member
Author
There was a problem hiding this comment.
In particular, was anyone aware of this feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4237 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 43 43
Lines 6315 6317 +2
=======================================
+ Hits 6313 6315 +2
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll hold off merging this one until we get a few eyes on it. The behaviour of references before and after
empty!was surprising to me, even though it's a direct consequence of what we're doing.