Skip to content

Fix Base.empty!(::GenericModel) and document its troublesome behavior - #4237

Open
odow wants to merge 1 commit into
masterfrom
od/fix-claude-016
Open

Fix Base.empty!(::GenericModel) and document its troublesome behavior#4237
odow wants to merge 1 commit into
masterfrom
od/fix-claude-016

Conversation

@odow

@odow odow commented Sep 3, 2026

Copy link
Copy Markdown
Member

I'll hold off merging this one until we get a few eyes on it. The behaviour of references before and after empty! was surprising to me, even though it's a direct consequence of what we're doing.

Comment thread src/JuMP.jl

julia> x === y
true
```

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In particular, was anyone aware of this feature

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (60cb1ee) to head (3e04eeb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4237   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          43       43           
  Lines        6315     6317    +2     
=======================================
+ Hits         6313     6315    +2     
  Misses          2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant