Add clojure.string-test.split-lines - #948
Merged
Merged
Conversation
jeaye
reviewed
Jul 27, 2026
| (when-var-exists str/split-lines | ||
| (deftest test-split-lines | ||
| (testing "Normal use" | ||
| #?(:cljr (is (= [] (str/split-lines ""))) |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated test namespace for clojure.string/split-lines, aligning it with the existing clojure.string-test.* coverage pattern in this test suite (feature-gated via when-var-exists for dialect/version portability).
Changes:
- Introduces
clojure.string-test.split-lineswith “Normal use” assertions for common newline cases (\n,\r\n, leading/trailing newlines, multiple newlines). - Adds invalid-input exception expectations (non-CLJS) using the suite’s portable
(p/thrown? …)assertion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeaye
requested changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.