Add tests for apply

[dgr]

No description provided.

[Copilot]

Pull request overview

Adds a new cross-dialect test namespace to exercise clojure.core/apply behavior within the existing clojure.core-test.* suite.

Changes:

• Introduces clojure.core-test.apply with assertions covering apply on empty seqables, mixed fixed args + seq args, and IFn invocations (map/keyword/vector/set).
• Uses the portability layer (when-var-exists, p/thrown?) to keep behavior consistent across supported dialects.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[E-A-Griffin]

apply with an inequality function (e.g. <) could be helpful given the wonkiness we've caught with these prior and how different these functions operate than their operator equivalents in most PLs

[dgr]

apply with an inequality function (e.g. <) could be helpful given the wonkiness we've caught with these prior and how different these functions operate than their operator equivalents in most PLs

What specifically are you trying to test? apply is pretty simple. It basically just validates that the first argument is an IFn and calls the correct arity with the supplied parameters. Given that, what do you think could go wrong with < that isn't verified by the test assertions in the current PR?

[jeaye]

apply with an inequality function (e.g. <) could be helpful given the wonkiness we've caught with these prior and how different these functions operate than their operator equivalents in most PLs

What specifically are you trying to test? apply is pretty simple. It basically just validates that the first argument is an IFn and calls the correct arity with the supplied parameters. Given that, what do you think could go wrong with < that isn't verified by the test assertions in the current PR?

Thanks for the idea, Emma! I agree with Dave here that this one shouldn't be needed. Keep 'em coming.

[dgr]

@jeaye , BTW, good idea to invoke the CoPilot review. I should do that more often. It caught a couple formatting things (trailing white space, comment on the wrong line, and a misspelling. I guess a little AI isn't a bad thing. :-)

[jeaye]

@jeaye , BTW, good idea to invoke the CoPilot review. I should do that more often. It caught a couple formatting things (trailing white space, comment on the wrong line, and a misspelling. I guess a little AI isn't a bad thing. :-)

I'm glad you're not annoyed by it! I've been using it for my jank PRs and it actually catches a lot. So far, it's definitely been worth my while. It's free for the jank-lang org, so, as you said, we might as well.

[jeaye]

LGTM. Awaiting approval from Emma, as she may have more comments.

[dgr]

OK, this should be ready now.

[dgr]

BTW, @E-A-Griffin , there are some tests of apply with comparison functions in gt_eq.cljc and lt_eq.cljc, so it's not completely untested.

[E-A-Griffin]

Let's get this merged!