feat: bump firebase versions in react package#198
Conversation
|
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~198 Documentation is deployed and generated using docs.page. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates Firebase version support to include Firebase 12.x alongside the existing Firebase 11.x support across the React package and related dependencies.
- Expands Firebase peer dependency to support both v11.3.0+ and v12.0.0+
- Updates root package Firebase dev dependency to v11.10.0
- Adds CI workflow to test Firebase 12 compatibility
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/package.json | Updates peer dependency to support Firebase 12 |
| package.json | Bumps dev dependency and adds Firebase 12 test script |
| examples/react-example/package.json | Updates Firebase dependency range to support v12 |
| dataconnect-sdk/js/default-connector/index.cjs.js | Code formatting changes (generated file) |
| dataconnect-sdk/js/default-connector/esm/package.json | JSON formatting change |
| dataconnect-sdk/js/default-connector/esm/index.esm.js | Code formatting changes (generated file) |
| .github/workflows/tests.yaml | Adds new CI job to test Firebase 12 compatibility |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
package.json:8
- Firebase version 12.0.0 does not exist. Firebase is currently at version 11.x. The peer dependency and test script reference a non-existent version.
"test:firebase12": "pnpm add -Dw firebase@^12.0.0 && firebase emulators:exec --project test-project \"pnpm turbo test:ci --filter=@tanstack-query-firebase/react\" && pnpm add -Dw firebase@^11.10.0 --ignore-workspace-root-check",
packages/react/package.json:48
- Firebase version 12.0.0 does not exist. This peer dependency range includes a non-existent version that could cause installation issues.
"firebase": "^11.3.0 || ^12.0.0"
examples/react-example/package.json:15
- Firebase version 12.0.0 does not exist. This dependency range includes a non-existent version.
"firebase": "^11.3.0 || ^12.0.0",
0a02c35 to
986a53f
Compare
5c958da to
0b26768
Compare
0b26768 to
15a4c9e
Compare
fed31c9 to
7cce88a
Compare
No description provided.