Conversation
isc-klu
force-pushed
the
integration-tests
branch
2 times, most recently
from
September 10, 2026 21:46
1219d08 to
1d42286
Compare
isc-klu
force-pushed
the
integration-tests
branch
3 times, most recently
from
September 10, 2026 22:59
e17b7bc to
d0543c2
Compare
Replaces the placeholder test with a suite that opens a multi-root workspace whose folders connect to one iris-community container by each supported mechanism (objectscript.conn host/port, docker-compose port resolution, intersystems.servers entry, isfs), plus an inactive folder pointing at an unreachable host. The container's /api/atelier session timeout is 10 s so expired-session recovery is exercised. Runs from a new prepare-release.yml workflow on PRs from prepare-* branches and on manual dispatch; the old npm test step is removed from the per-PR workflows. Also fixes the runner, which could not launch VS Code at all: bump @vscode/test-electron to 3.x (2.x looks for the renamed Contents/MacOS/Electron), drop the rejected -n arg, unset ELECTRON_RUN_AS_NODE inherited from extension-spawned terminals, use a fresh user-data-dir per run, and make the mocha runner's promise settle when the tests finish. Closes intersystems-community#1863 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
isc-klu
force-pushed
the
integration-tests
branch
from
September 11, 2026 14:43
d0543c2 to
ebb7dbe
Compare
Run the IRIS containers under Podman and drop the runner's Docker Compose so the extension's docker-compose connection resolves through Podman too. Fixes the docker-compose case (needs objectscript.conn.active) and stops the post-timeout round-trip from re-verifying delete-sync, which older releases don't re-wire after a session lapses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1863. Integration suite against real
iris-community:latest-cdcontainers, run by a newprepare-release.ymlworkflow onprepare-*PRs and on manual dispatch (Podman on the runner).What runs
src/test/cases.tsgenerates one.code-workspaceper case intotest-fixtures/.generated/;runTest.tsopens each in a downloaded VS Code with the released Server Manager installed alongside, andsrc/test/suite/extension.test.tsruns the checks that apply. 12 launches across four connection shapes ×-named/-anonymous× (-active/-inactivewhere it applies).test-fixtures/README.mdis the full matrix, the container layout, and how to run it locally.Two containers back every case:
iris(password only) andiris-anon(unauthenticated only), each with a 10-second/api/ateliersession timeout so expired-session recovery meets a real 401.Coverage
objectscript.connwith host/port/credentialsobjectscript.conn.docker-composeport resolution (through Podman)objectscript.conn.servernaming anintersystems.serversentryisfs://folder on an entry (noobjectscript.conn)Each case, in a fresh user-data-dir: resolves without prompting (host, port, ns, credentials as configured); a class written through the folder syncs to the server and back on delete iff the connection is active; flipping
objectscript.conn.activeis honored (host and sm); aserverSidefolder lists the namespace; and Server Manager'sgetServerSpecreturns the configured spec. Every check then repeats past the session timeout so a lapsed cookie must be renewed. Any credential prompt fails the case, since VS Code suppresses modal dialogs in tests and the input box would block to the mocha timeout.Runner fixes
npm testcould not launch VS Code:@vscode/test-electron2.x looks for the since-renamedContents/MacOS/Electron(bumped to 3.x); Electron rejects-n;ELECTRON_RUN_AS_NODEfrom an extension-spawned terminal made VS Code run as plain Node; the mocha promise settled before the tests ran.🤖 Generated with Claude Code