Skip to content

OF-3366: e2e tests for FAST - #3494

Merged
Fishbowler merged 3 commits into
igniterealtime:mainfrom
Fishbowler:fast-e2e
Sep 12, 2026
Merged

OF-3366: e2e tests for FAST#3494
Fishbowler merged 3 commits into
igniterealtime:mainfrom
Fishbowler:fast-e2e

Conversation

@Fishbowler

Copy link
Copy Markdown
Member

Test general FAST token usage with Conversations, plus token rotation.

The 2nd commit is some refactoring to reduce test duplication - this might be easier to review commit-by-commit.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: ae305d7d-67f7-4a22-98e1-daa27a44489e

📥 Commits

Reviewing files that changed from the base of the PR and between 0e3cde1 and e9299f2.

📒 Files selected for processing (13)
  • .github/actions/conversationstest-action/run-tests.sh
  • .github/workflows/continuous-integration-workflow.yml
  • build/ci/conversations/configs/fast-rotation.xml
  • build/ci/conversations/flows/README.md
  • build/ci/conversations/flows/bind2.yaml
  • build/ci/conversations/flows/cb.yaml
  • build/ci/conversations/flows/fast-rotation.yaml
  • build/ci/conversations/flows/fast.yaml
  • build/ci/conversations/flows/sasl2.yaml
  • build/ci/conversations/flows/scripts/checkForLogs.js
  • build/ci/conversations/flows/simple.yaml
  • build/ci/conversations/flows/subflows/dismiss-onboarding-dialogs.yaml
  • build/ci/conversations/flows/subflows/login.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change adds a dedicated Openfire configuration and CI matrix entry for FAST token rotation. It introduces reusable login and onboarding Maestro subflows and updates existing flows to use them. It adds polling support for delayed sidecar logs. New flows verify FAST caching, SASL2 quick start, token rotation, and rotated-token reuse.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e9299

No concrete merge-blocking risk remains in the FAST test coverage changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly matches the changes. It describes FAST token usage, token rotation, and refactoring to reduce test duplication.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Fishbowler
Fishbowler merged commit e2a4e79 into igniterealtime:main Sep 12, 2026
44 checks passed
@Fishbowler
Fishbowler deleted the fast-e2e branch September 12, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants