feat(compose): add optional GitHub sync service - #332
Open
YannJY02 wants to merge 2 commits into
Open
Conversation
Resolve the profile-gated GitHub service through Docker DNS at request time so nginx starts when the profile is disabled. Document the issue_comment webhook subscription required for issue and pull request comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
githubCompose profilehuly_v7.confissue_commentsubscription required for issue and pull request commentsDefault deployments remain unchanged: the service is disabled until
COMPOSE_PROFILES=githubis configured, and nginx resolves the optional service only when a request reaches the GitHub route.Validation
bash -n setup.shsh -n setup.shgit diff --checkgithubprofile service lists withdocker compose config --servicesws://collaborator:3078, Redpanda, and no host portgithubDNS target to verify the default profile remains availableNo credentials, private deployment URLs, or generated local configuration are included.
Refs #179, #296, #297. Related to #300.