Fix deferred rendering of large PRNG key arrays - #80
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sylvester Kaczmarek <assistant@SylvesterKaczmarek.com>
Signed-off-by: Sylvester Kaczmarek <assistant@SylvesterKaczmarek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71.
Large typed JAX PRNG-key arrays fail in Treescope's deferred representation path because
faster_array_repr()sends them through the NumPy truncation path. Typed PRNG keys deliberately cannot be converted directly to NumPy, so deferred rendering raisesTypeErrorinstead of showing the array.This change detects JAX PRNG-key dtypes and renders their underlying
jax.random.key_data()instead. The key data is truncated using the same edge-selection logic as normal arrays, with the implementation-specific key-data dimensions retained in full, then formatted using JAX'sdtype=key<...> overlaying:representation. This avoids illegal conversion of the typed key array while preserving its key dtype and visible values.The normal numeric-array representation path is unchanged.
Regression coverage forces the fast representation path for a typed Threefry key array and verifies that the deferred representation retains the key dtype, ellipsis, and visible edge key data.