Skip to content

feat(derived): Reconcile GroupDerivedData rows with inconsistent status - #123853

Draft
kcons wants to merge 3 commits into
masterfrom
kcons/okactually
Draft

feat(derived): Reconcile GroupDerivedData rows with inconsistent status#123853
kcons wants to merge 3 commits into
masterfrom
kcons/okactually

Conversation

@kcons

@kcons kcons commented Sep 8, 2026

Copy link
Copy Markdown
Member

We need the log-derived status to match the actual one.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 8, 2026
@kcons

kcons commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

bugbot review

category=OutboxCategory.GROUP_ACTION_LOG_EVENT,
)
return (
CellOutbox.objects.filter(**filter_kwargs).exists()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can drop this part.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5ae00c1. Configure here.

group_id=group.id,
project=group.project,
actor=SYSTEM_ACTOR,
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale reconcile overwrites newer status

Medium Severity

The last pending-outbox check and publish_action are not atomic with a group-status re-read. A concurrent resolve or unresolve can commit first; this path then appends a ReconcileStatusAction with the earlier target, so derived processing applies that stale reconcile after the newer action and leaves log-derived status wrong until another view.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5ae00c1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant