fix(alerts): avoid 500 on partial issue-alert PUT missing actionMatch - #122401
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
fix(alerts): avoid 500 on partial issue-alert PUT missing actionMatch#122401sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Project rule details uses a partial serializer, so clients can omit actionMatch/name. Look those fields up with .get() and let ProjectRuleUpdater keep existing values when they are absent. Fixes SENTRY-5PKS
github-actions
Bot
added
the
Scope: Backend
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial
PUTs to the project rule details endpoint can omitactionMatch/namebecause the serializer ispartial=True. The handler still used required-key access (data["actionMatch"],data["name"]), which 500s those requests.Use
.get()for those fields and letProjectRuleUpdaterkeep existing rule values when they are absent (Nonemeans do not update).Test plan
test_partial_update_without_action_matchFixes SENTRY-5PKS
--
View Junior Session [Sentry]