Skip to content

[DRAFT] Type sentry.snuba.metrics.query_builder and remove weaklist entry - #122397

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-ca7c
Draft

[DRAFT] Type sentry.snuba.metrics.query_builder and remove weaklist entry#122397
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-ca7c

Conversation

@cursor

@cursor cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • removed sentry.snuba.metrics.query_builder from the mypy typing-issues override list
  • removed sentry.snuba.metrics.query_builder from the mypy weaklist in pyproject.toml
  • fixed all typing issues in src/sentry/snuba/metrics/query_builder.py to satisfy strict mypy (including missing annotations, union narrowing, and typed params handling)

Testing

  • source .venv/bin/activate && mypy --config pyproject.toml src/sentry/snuba/metrics/query_builder.py
  • source .venv/bin/activate && python -m tools.mypy_helpers.mypy_without_ignores src/sentry/snuba/metrics/query_builder.py
  • source .venv/bin/activate && python -m tools.mypy_helpers.check_stronglist pyproject.toml
  • source .venv/bin/activate && .venv/bin/prek run -q
  • attempted but environment-blocked due missing local Redis/Docker services:
    • source .venv/bin/activate && .venv/bin/pytest -n3 -svv --reuse-db tests/sentry/snuba/metrics/test_query_builder.py
    • source .venv/bin/activate && SENTRY_SKIP_SERVICE_VALIDATION=1 .venv/bin/pytest -n3 -svv --reuse-db tests/sentry/snuba/metrics/test_query_builder.py

@armenzg could you review this draft PR?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 21, 2026
@getsantry

getsantry Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant