Remove @internal phpdoc from HttpClient - #1841
Merged
cleptric merged 3 commits intoJun 10, 2025
Merged
Conversation
cleptric
requested changes
Jun 3, 2025
Comment on lines
-10
to
-12
| /** | ||
| * @internal | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
It is declared as non–final and its fields are protected, so it can be inherited in userland.
Member
There was a problem hiding this comment.
We are not guaranteeing any BC in our Client. We want to be able to make breaking changes even in minors, hence it's marked as @internal.
cleptric
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818