test(cloudflare): Add integration tests for scheduled, D1, and workflow#20609
Open
test(cloudflare): Add integration tests for scheduled, D1, and workflow#20609
Conversation
JPeer264
force-pushed
the
jp/cloudflare-integration-tests
branch
from
8241ad2 to
204c0ae
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 204c0ae. Configure here.
| }), | ||
| ); | ||
| }) | ||
| .start(signal); |
There was a problem hiding this comment.
D1 test missing .unordered() risks flaky ordering
Low Severity
The D1 test expects two transaction envelopes (GET /init then GET /query) in strict order without calling .unordered(). Since the SDK flushes telemetry asynchronously via waitUntil, the second transaction could arrive at the mock server before the first, causing the ordered assertion to fail. Every other multi-envelope test in this project (hono-sdk, hono-integration, durableobject, workflow) uses .unordered() to avoid this. The two expectations are already distinguishable by transaction name, so .unordered() would be safe here.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 204c0ae. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16894
closes JS-677
This adds only basic integration tests for D1,
scheduledof an exported handler and a Workflow.